Added clearing reminder, bug fix for #190 and #163, and changed date description for reminder deadline #203
Conversation
minpyaemoe
commented
Nov 2, 2019
•
minpyaemoe
commented
- Clear command will now clear all reminders
- Bug fix for empty string message, Fixes Reminder message can be blank #190
- Bug fix for special character in spending name. Fixes Adding spendings with special characters #163
- Date description for overdue task changed
- Edited UG respectively
minpyaemoe
changed the title
docs/UserGuide.adoc
Outdated
| @@ -467,20 +467,25 @@ A graph is shown. | |||
| // end::graph[] | |||
|
|
|||
| === Adding a reminder: `reminder add` | |||
| Adds a reminder to the reminder list | |||
| Adds a reminder to the reminder list when user enters a new reminder. Deadline and reminder message are recorded into storage. | |||
There was a problem hiding this comment.
Don't have to mention that it is recorded into storage.
docs/UserGuide.adoc
Outdated
| *Format:* `reminder add d/DATE m/MESSAGE` | ||
|
|
||
| [NOTE] | ||
| The date of a deadline must be within 5 years from the current date. MoneyGoWhere will check if the given reminder message and deadline are valid. If it encounters invalid information such as empty message, the application will notify with error. |
There was a problem hiding this comment.
If it encounters invalid information such as an empty message, the application will display an error.
docs/UserGuide.adoc
Outdated
| @@ -613,6 +618,9 @@ The most recent undo command is reversed. | |||
| Clears all entries from the application. + | |||
| *Format:* `clear` | |||
|
|
|||
| [NOTE] | |||
| This command clears all the stored information which includes reminders and spending , and also reset the application to the initial state with budget set to $1000. | |||
There was a problem hiding this comment.
This command clears all stored information, including reminders and spending, and sets the budget to a default value of $1000.
| ReminderMessage message = ParserUtil.parseMessage(reminderMessage); | ||
|
|
||
| if (date.dateValue.isAfter(LocalDate.now()) | ||
| && date.dateValue.getYear() - LocalDate.now().getYear() > ParserUtil.DATE_TOO_FAR_RANGE) { |
There was a problem hiding this comment.
We could probably also limit this to past reminders. Reminders 5 years ago should not be added.
There was a problem hiding this comment.
I guess we can. May be the spending as well?
There was a problem hiding this comment.
Good consideration, can create an issue
docs/UserGuide.adoc
Outdated
| @@ -467,12 +467,12 @@ A graph is shown. | |||
| // end::graph[] | |||
|
|
|||
| === Adding a reminder: `reminder add` | |||
| Adds a reminder to the reminder list when user enters a new reminder. Deadline and reminder message are recorded into storage. | |||
| Adds a reminder to the reminder list when user enters a new reminder. This command records a reminder together with its message and deadline. | |||
There was a problem hiding this comment.
Adds a reminder to the reminder list. Key information such as deadline and message are recorded.
Please change this line to the above so that the description is clearer and to avoid repetition. It should match the format input sequence being described.
Apart from this, everything else looks fine!
